Upgrade to React 18 #1759
Upgrade to React 18 #1759
Conversation
* Updated React, React Leaflet, and associated packages * Call createRoot instead of ReactDOM.render * Updates to match changes to types in React 18 * Removed ref workaround in Map component * Added babel-jest to transpile some new React Leaflet code that uses ES modules * Removed React Hooks Testing Library, moved to React Testing Library's renderHook API. * Moved a bunch of tests from react-test-renderer to RTL to resolve issues
The leaflet.fullscreen package includes its own implementation of screenfull, but that ends up causing issues in tests and I can't figure out how to properly get it to find its own implementation of screenfull, or mock my own. As a result, I have added screenfull as a separate dependency but for dev only to make the tests work.
| expect(tree).toMatchSnapshot() | ||
| }) | ||
|
|
||
| test("renders with vehicles and selected vehicles", () => { |
There was a problem hiding this comment.
Note: I've removed this (and I think a couple of other places that test rendering selected vehicles) because #1748 moved the rendering of the VPP outside of the page component.
Coverage of commit
|
|
Also note: I think the test "Shuttle Map Page renders with shapes selected" is actually broken (not just with the upgrade, the original snapshot doesn't look like it demonstrates what the name of the test says it's demonstrating). I'll see if I can fix that as part of this PR, or otherwise create a followup ticket. |
|
More generally, I'm going to give this another pass (probably tomorrow) and see if any of the snapshot tests can easily be reworked into more traditional React Testing Library tests so that we don't have to review those huge diffs anymore. I don't want to spend too much time trying to remove snapshot tests as part of this particular PR though just because it's already got a lot going on. |
Coverage of commit
|
lemald
force-pushed
the
lem-react-18
branch
2 times, most recently
from
c65ccbb to
64f8075
Compare
Coverage of commit
|
Asana ticket: ⚙️ Upgrade to React 18
Unfortunately these changes are very heavily front-loaded into the first commit. However, that commit description does include a breakdown of what changes are included. The following commits are smaller but should be better broken down.