feat: Add endpoint showing the currently-deployed version #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshlarson
commented
Apr 22, 2024
•
joshlarson
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1207101804432602
firestack
reviewed
Apr 22, 2024
| use SkateWeb, :controller | ||
|
|
||
| def version(conn, _params) do | ||
| send_resp(conn, 200, Application.get_env(:skate, :version)) |
There was a problem hiding this comment.
suggestion(non-blocking): IMO it's more useful to get this at compile time than runtime. I dunno about testing here though...
Suggested change
| send_resp(conn, 200, Application.get_env(:skate, :version)) | |
| send_resp(conn, :ok, Application.compile_env(:skate, :version)) |
There was a problem hiding this comment.
I got 👇 error 😭
(RuntimeError) Application.compile_env/3 cannot be called inside functions, only in the module body
There was a problem hiding this comment.
firestack
reviewed
Apr 22, 2024
| use SkateWeb, :controller | ||
|
|
||
| def version(conn, _params) do | ||
| send_resp(conn, 200, Application.get_env(:skate, :version)) |
There was a problem hiding this comment.
Suggested change
| send_resp(conn, 200, Application.get_env(:skate, :version)) | |
| send_resp(conn, :ok, Application.get_env(:skate, :version)) |
|
Seems to work - that's cool! |
Coverage of commit
|
firestack
reviewed
Apr 22, 2024
Comment on lines
3
to
6
|
|
||
| def version(conn, _params) do | ||
| send_resp(conn, 200, Application.get_env(:skate, :version)) | ||
| end |
There was a problem hiding this comment.
Suggested change
| def version(conn, _params) do | |
| send_resp(conn, 200, Application.get_env(:skate, :version)) | |
| end | |
| @version Application.compile_env(:skate, :version) | |
| def version(conn, _params) do | |
| send_resp(conn, :ok, @version) | |
| end |
There was a problem hiding this comment.
Yeah... that does mess up the tests though. I guess the value of testing this endpoint at all is pretty minimal though 🙃
Coverage of commit
|
firestack
reviewed
Apr 22, 2024
firestack
approved these changes
Apr 22, 2024
Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.