Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ex/application): add deployment version to startup log #2587

Merged
merged 1 commit into from
May 9, 2024
Merged

feat(ex/application): add deployment version to startup log #2587

merged 1 commit into from
May 9, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented May 9, 2024 •
edited
Loading

I was working on Splunk CSRF Login Issue Dashboard and didn't have access to deployment version info in Splunk, so this felt like it should be easy to add.

Asana Ticket: https://app.asana.com/0/0/1207280328006578/f

@firestack firestack self-assigned this May 9, 2024
@firestack firestack requested a review from a team as a code owner May 9, 2024 20:25
@firestack firestack force-pushed the kf/jj/wrqwvzwnvzmm branch 3 times, most recently from 4de7c8b to 2d1f1dd Compare May 9, 2024 20:41
@firestack firestack force-pushed the kf/jj/wrqwvzwnvzmm branch from 2d1f1dd to f1497c1 Compare May 9, 2024 20:41
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Coverage of commit f1497c1

Summary coverage rate:
  lines......: 93.7% (3232 of 3448 lines)
  functions..: 73.4% (1337 of 1822 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/application.ex                                        |94.1%     17|75.0%     4|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Coverage of commit f1497c1

Summary coverage rate:
  lines......: 93.7% (3232 of 3448 lines)
  functions..: 73.4% (1337 of 1822 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/application.ex                                        |94.1%     17|75.0%     4|    -      0

Download coverage report

@firestack firestack enabled auto-merge (squash) May 9, 2024 20:51
hannahpurcell
hannahpurcell approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@firestack firestack merged commit eb1aa60 into main May 9, 2024
15 checks passed
@firestack firestack deleted the kf/jj/wrqwvzwnvzmm branch May 9, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees

@firestack firestack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firestack @hannahpurcell