feat: Direct About Skate clicks to the /user-guide endpoint
#2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
commented
May 10, 2024
Coverage of commit
|
joshlarson
force-pushed
the
jdl/feat/about-link-to-user-guide
branch
from
ae2c5dd to
cd30730
Compare
Coverage of commit
|
firestack
reviewed
May 13, 2024
Comment on lines
181
to
185
| <NavLink | ||
| className={({ isActive }) => | ||
| "c-left-nav__link" + | ||
| (isActive ? " c-left-nav__link--active" : "") | ||
| } |
There was a problem hiding this comment.
question: This doesn't go anywhere within the app, so I'm wondering, what benefits do we get from using <NavLink> here over an <a>?
There was a problem hiding this comment.
Hmmm - probably not much benefit, huh.
There was a problem hiding this comment.
Flawless victory
There was a problem hiding this comment.
Sooo I think we gain some benefit in consistency. Even if we don't need all of the features of NavLink, we still get the benefit of it effortlessly looking like the other links in this section!
There was a problem hiding this comment.
Coverage of commit
|
firestack
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/1148853526253420/1206673444071869/f