feat: Allow RoutePropertiesCard to be open to "variants" or "stops" by default #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
force-pushed
the
jdl/tests/simplify-rpc-tests
branch
from
6b171e7 to
d12f582
Compare
joshlarson
force-pushed
the
jdl/feat/rpc-can-be-open-by-default
branch
from
0e2db63 to
11d6fc5
Compare
Coverage of commit
|
joshlarson
force-pushed
the
jdl/tests/simplify-rpc-tests
branch
from
d12f582 to
47d3d4b
Compare
joshlarson
force-pushed
the
jdl/feat/rpc-can-be-open-by-default
branch
from
e222187 to
87575e5
Compare
Coverage of commit
|
Coverage of commit
|
Comment on lines
99
to
108
| export const WithVariantsOpenedByDefault: Story = { | ||
| args: { | ||
| defaultOpened: "variants", | ||
| }, | ||
| } | ||
| export const WithStopsOpenedByDefault: Story = { | ||
| args: { | ||
| defaultOpened: "stops", | ||
| }, | ||
| } |
There was a problem hiding this comment.
I'm on the fence about including these two stories, because these stories don't really surface a UI variation of the card, but rather serve as a kind of test that the parameter of "default openness" is getting correctly applied. If we ever had a regression in that "openness" variable, the below tests would catch it.
There was a problem hiding this comment.
The reason I thought it was a good idea is that if anything ever changes about how the two "open" states look, Chromatic wouldn't catch it on the other stories where they default to closed.
I'm not attached to doing this - it's kind of small potatoes stakes - but that's what I was thinking when I added these.
There was a problem hiding this comment.
Oh I seeeeeee, I see. Ok yeah, I was very easily persuaded. It makes sense to want some record of the look of those open states.
joshlarson
force-pushed
the
jdl/tests/simplify-rpc-tests
branch
from
47d3d4b to
d75281d
Compare
joshlarson
changed the base branch from
jdl/tests/simplify-rpc-tests
to
jdl/stories/story-for-route-properties-card
joshlarson
force-pushed
the
jdl/stories/story-for-route-properties-card
branch
from
5f7ae18 to
f9074b3
Compare
joshlarson
force-pushed
the
jdl/feat/rpc-can-be-open-by-default
branch
from
87575e5 to
fafcc08
Compare
Coverage of commit
|
joshlarson
force-pushed
the
jdl/feat/rpc-can-be-open-by-default
branch
from
fafcc08 to
362869c
Compare
joshlarson
force-pushed
the
jdl/stories/story-for-route-properties-card
branch
from
32efbe9 to
648cb8d
Compare
joshlarson
force-pushed
the
jdl/feat/rpc-can-be-open-by-default
branch
2 times, most recently
from
699aed1 to
58471e1
Compare
Base automatically changed from
jdl/stories/story-for-route-properties-card
to
main
May 20, 2024 19:10
joshlarson
force-pushed
the
jdl/feat/rpc-can-be-open-by-default
branch
from
58471e1 to
7e93587
Compare
Coverage of commit
|
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/0/1207363543546275/f