feat(ts/hooks/useDetour): replace state variable with state machine
#2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
hannahpurcell
approved these changes
May 22, 2024
There was a problem hiding this comment.
This makes sense to me from an iterative perspective. (So while the Idle/Done split doesn't seem to be needed here, I know it's developed further in the later PR, so I'm approving this one and looking more closely at the subsequent one. Function otherwise looks good.) Noted one proposed wording change, but non-blocking.
firestack
force-pushed
the
kf/asn/state-machine/state-var
branch
from
e8b1719 to
c5999e0
Compare
Coverage of commit
|
firestack
force-pushed
the
kf/asn/state-machine/state-var
branch
from
c5999e0 to
ed07886
Compare
Coverage of commit
|
joshlarson
reviewed
May 23, 2024
joshlarson
approved these changes
May 23, 2024
There was a problem hiding this comment.
Looks good to me!
I made a comment that I'm interested in your thoughts on, but 👍 either way.
firestack
force-pushed
the
kf/asn/state-machine/state-var
branch
from
ed07886 to
5f13e11
Compare
firestack
force-pushed
the
kf/asn/state-machine/state-var
branch
from
5f13e11 to
d933c71
Compare
firestack
force-pushed
the
kf/asn/state-machine/state-var
branch
from
d933c71 to
cfdc141
Compare
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting #2615 up into two PR's, while trying to preserve context.
#2607 (comment)
Asana Ticket: https://app.asana.com/0/0/1207381767522633/f