feat: Made searchForm into generic combobox with two variations (for search & select)

[hannahpurcell]

There is 1 failing test, but I can't test it without the vpn! Will do tomorrow at the office

[firestack]

I have a few thoughts on this but haven't been able to read through and grok all the code yet, sorry!

I'm running out of time today, so I'll try and look at this later tonight or tomorrow morning at the very latest

[github-actions]

Coverage of commit e0cc1c7

Summary coverage rate:
  lines......: 93.6% (3256 of 3480 lines)
  functions..: 73.3% (1342 of 1830 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

[firestack]

nit(non-blocking): we chatted about this in a huddle, but it may be beneficial if we rename this from Combobox to something about how this is a Map search OR route select at this moment.

I'll post the combobox refactor ticket we talked about on this comment thread for posterity once it's created.

[hannahpurcell]

Ah that's right, I remember discussing, but I'm not sure what options were preferred. Rename from Combobox to InputBoxWithDropdown or DropdownSearchOrSelect or something of the sort?

[firestack]

Feeling good that all feedback is either addressed or being addressed, left one more nit if you want to do it, otherwise I don't think I need to rereview 👍🏻

[github-actions]

Coverage of commit e42d8a0

Summary coverage rate:
  lines......: 93.6% (3257 of 3480 lines)
  functions..: 73.4% (1343 of 1830 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

[github-actions]

Coverage of commit b2f0cd3

Summary coverage rate:
  lines......: 93.6% (3256 of 3480 lines)
  functions..: 73.3% (1342 of 1830 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report