Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Don't allow creating GTFS-TM messages for routes with duplicate stops #2669

Merged
merged 1 commit into from
Jun 24, 2024
Merged

feat: Don't allow creating GTFS-TM messages for routes with duplicate stops #2669

merged 1 commit into from
Jun 24, 2024

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented Jun 21, 2024 •
edited
Loading

@joshlarson joshlarson force-pushed the jdl/feat/gtfs-tm-reject-routes-with-duplicate-stops branch from 449113b to ca2aba2 Compare June 21, 2024 21:59
@joshlarson joshlarson marked this pull request as ready for review June 21, 2024 22:00
@joshlarson joshlarson requested a review from a team as a code owner June 21, 2024 22:00
@joshlarson joshlarson enabled auto-merge (squash) June 21, 2024 22:00
@github-actions GitHub Actions
Copy link

Coverage of commit ca2aba2

Summary coverage rate:
  lines......: 93.7% (3272 of 3493 lines)
  functions..: 73.5% (1346 of 1831 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/realtime/trip_modification.ex                               | 100%     12| 100%     3|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit ca2aba2

Summary coverage rate:
  lines......: 93.6% (3271 of 3493 lines)
  functions..: 73.5% (1346 of 1831 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/realtime/trip_modification.ex                               | 100%     12| 100%     3|    -      0

Download coverage report

firestack
firestack requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address the comment about factories and clean up the tests a little but otherwise this looks good

firestack
firestack approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on #2669 (comment) in a separate PR

@joshlarson joshlarson merged commit 5686a83 into main Jun 24, 2024
45 checks passed
@joshlarson joshlarson deleted the jdl/feat/gtfs-tm-reject-routes-with-duplicate-stops branch June 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

Assignees

@joshlarson joshlarson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlarson @firestack