refactor: Rename "finish" variables and functions to "review"

assets/src/components/detours/diversionPage.tsx

@@ -77,7 +77,7 @@ export const DiversionPage = ({
     canUndo,
     undo,
     clear,
-    finishDetour,
+    reviewDetour,
     editDetour,
   } = useDetour(originalRoute)
 
@@ -198,8 +198,8 @@ export const DiversionPage = ({
               routeDescription={routeDescription ?? "??"}
               routeOrigin={routeOrigin ?? "??"}
               routeDirection={routeDirection ?? "??"}
-              detourFinished={finishDetour !== undefined}
-              onFinishDetour={finishDetour}
+              detourFinished={reviewDetour !== undefined}
+              onReviewDetour={reviewDetour}
               onChangeRoute={
                 inTestGroup(TestGroups.DetourRouteSelection)
                   ? () => send({ type: "detour.route-pattern.open" })

assets/src/components/detours/diversionPanel.tsx

@@ -15,7 +15,7 @@ export interface DiversionPanelProps {
   routeOrigin: string
   routeDirection: string
   detourFinished?: boolean
-  onFinishDetour?: () => void
+  onReviewDetour?: () => void
   onChangeRoute?: () => void
 }
 
@@ -27,7 +27,7 @@ export const DiversionPanel = ({
   routeOrigin,
   routeDirection,
   detourFinished,
-  onFinishDetour,
+  onReviewDetour,
   onChangeRoute,
 }: DiversionPanelProps) => (
   <Panel as="article" className="c-diversion-panel">
@@ -103,7 +103,7 @@ export const DiversionPanel = ({
       </Panel.Body.ScrollArea>
 
       <Panel.Body.Footer hidden={!detourFinished}>
-        <Button className="flex-grow-1 m-3" onClick={onFinishDetour}>
+        <Button className="flex-grow-1 m-3" onClick={onReviewDetour}>
           Review Detour
         </Button>
       </Panel.Body.Footer>

assets/src/hooks/useDetour.ts

@@ -108,7 +108,7 @@ export const useDetour = (input: CreateDetourMachineInput) => {
     send({ type: "detour.edit.clear-detour" })
   }
 
-  const finishDetour = () => {
+  const reviewDetour = () => {
     send({ type: "detour.edit.done" })
   }
 
@@ -206,8 +206,8 @@ export const useDetour = (input: CreateDetourMachineInput) => {
     clear,
 
     /** When present, puts this detour in "finished mode" */
-    finishDetour: snapshot.can({ type: "detour.edit.done" })
-      ? finishDetour
+    reviewDetour: snapshot.can({ type: "detour.edit.done" })
+      ? reviewDetour
       : undefined,
     /** When present, puts this detour in "edit mode" */
     editDetour,

assets/tests/components/detours/diversionPage.test.tsx

@@ -20,8 +20,8 @@ import { DiversionPage as DiversionPageDefault } from "../../../src/components/d
 import stopFactory from "../../factories/stop"
 import userEvent from "@testing-library/user-event"
 import {
-  finishDetourButton,
   originalRouteShape,
+  reviewDetourButton,
 } from "../../testHelpers/selectors/components/detours/diversionPage"
 import {
   finishedDetourFactory,
@@ -898,7 +898,7 @@ describe("DiversionPage", () => {
       fireEvent.click(originalRouteShape.get(container))
     })
 
-    await userEvent.click(finishDetourButton.get())
+    await userEvent.click(reviewDetourButton.get())
 
     expect(
       screen.queryByRole("heading", { name: "Create Detour" })
@@ -919,7 +919,7 @@ describe("DiversionPage", () => {
       fireEvent.click(originalRouteShape.get(container))
     })
 
-    await userEvent.click(finishDetourButton.get())
+    await userEvent.click(reviewDetourButton.get())
 
     expect(screen.getByRole("alert")).toHaveTextContent(
       "Detour shape is not editable from this screen."
@@ -937,7 +937,7 @@ describe("DiversionPage", () => {
       fireEvent.click(originalRouteShape.get(container))
     })
 
-    await userEvent.click(finishDetourButton.get())
+    await userEvent.click(reviewDetourButton.get())
 
     await waitFor(() => {
       expect(screen.getByRole("button", { name: "Undo" })).toBeDisabled()
@@ -956,7 +956,7 @@ describe("DiversionPage", () => {
       fireEvent.click(originalRouteShape.get(container))
     })
 
-    await userEvent.click(finishDetourButton.get())
+    await userEvent.click(reviewDetourButton.get())
 
     expect(screen.getByRole("button", { name: "Edit Detour" })).toBeVisible()
   })
@@ -972,7 +972,7 @@ describe("DiversionPage", () => {
       fireEvent.click(originalRouteShape.get(container))
     })
 
-    await userEvent.click(finishDetourButton.get())
+    await userEvent.click(reviewDetourButton.get())
 
     await userEvent.click(
       await screen.findByRole("button", { name: "Edit Detour" })
@@ -1002,7 +1002,7 @@ describe("DiversionPage", () => {
       fireEvent.click(originalRouteShape.get(container))
     })
 
-    await userEvent.click(finishDetourButton.get())
+    await userEvent.click(reviewDetourButton.get())
 
     expect(screen.getByRole("button", { name: "Copy Details" })).toBeVisible()
   })
@@ -1067,7 +1067,7 @@ describe("DiversionPage", () => {
       fireEvent.click(originalRouteShape.get(container))
     })
 
-    await userEvent.click(finishDetourButton.get())
+    await userEvent.click(reviewDetourButton.get())
 
     await userEvent.click(screen.getByRole("button", { name: "Copy Details" }))
 

assets/tests/testHelpers/selectors/components/detours/diversionPage.tsx

@@ -1,7 +1,7 @@
 import { expect } from "@jest/globals"
 import { byRole } from "testing-library-selector"
 
-export const finishDetourButton = byRole("button", { name: "Review Detour" })
+export const reviewDetourButton = byRole("button", { name: "Review Detour" })
 
 export const originalRouteShape = {
   interactive: {