Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: truncate aws location queries to 200 bytes #2702

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix: truncate aws location queries to 200 bytes #2702

merged 2 commits into from
Aug 1, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented Jul 23, 2024 •
edited
Loading

@firestack firestack force-pushed the kf/asn/fix-aws-location-search-text branch from ff67eff to 4c39573 Compare July 25, 2024 19:17
@firestack firestack force-pushed the kf/asn/fix-aws-location-search-text branch from 4c39573 to 760b00c Compare July 25, 2024 20:34
@firestack firestack changed the title fix: truncate aws location queries to 200 {graphimes?/bytes?} fix: truncate aws location queries to 200 bytes Jul 25, 2024
@firestack firestack changed the base branch from main to kf/asn/update-elixir July 25, 2024 20:35
@firestack firestack force-pushed the kf/asn/update-elixir branch from cbd6097 to a652e10 Compare July 25, 2024 20:38
@firestack firestack force-pushed the kf/asn/fix-aws-location-search-text branch from 760b00c to 69bb85d Compare July 25, 2024 20:38
@firestack firestack force-pushed the kf/asn/update-elixir branch from a652e10 to ee4124b Compare July 25, 2024 20:40
@firestack firestack force-pushed the kf/asn/fix-aws-location-search-text branch from 69bb85d to 76aa94a Compare July 25, 2024 20:40
@github-actions GitHub Actions
Copy link

Coverage of commit 76aa94a

Summary coverage rate:
  lines......: 93.1% (3307 of 3552 lines)
  functions..: 72.3% (1342 of 1855 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/location_search/aws_location_request.ex               |97.4%     38| 100%     8|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 76aa94a

Summary coverage rate:
  lines......: 93.1% (3307 of 3552 lines)
  functions..: 72.3% (1342 of 1855 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/location_search/aws_location_request.ex               |97.4%     38| 100%     8|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 76aa94a

Summary coverage rate:
  lines......: 93.1% (3307 of 3552 lines)
  functions..: 72.3% (1342 of 1855 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/location_search/aws_location_request.ex               |97.4%     38| 100%     8|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 76aa94a

Summary coverage rate:
  lines......: 93.1% (3307 of 3552 lines)
  functions..: 72.3% (1342 of 1855 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/location_search/aws_location_request.ex               |97.4%     38| 100%     8|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 76aa94a

Summary coverage rate:
  lines......: 93.1% (3307 of 3552 lines)
  functions..: 72.3% (1342 of 1855 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/location_search/aws_location_request.ex               |97.4%     38| 100%     8|    -      0

Download coverage report

@firestack firestack marked this pull request as ready for review July 25, 2024 20:48
@firestack firestack requested a review from a team as a code owner July 25, 2024 20:48
Base automatically changed from kf/asn/update-elixir to main July 26, 2024 13:49
An error occurred while trying to automatically change base from kf/asn/update-elixir to main July 26, 2024 13:49
hannahpurcell
hannahpurcell approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@firestack firestack force-pushed the kf/asn/fix-aws-location-search-text branch from 76aa94a to 2226302 Compare July 29, 2024 14:33
@github-actions GitHub Actions
Copy link

Coverage of commit 2226302

Summary coverage rate:
  lines......: 93.0% (3318 of 3566 lines)
  functions..: 72.5% (1356 of 1870 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/location_search/aws_location_request.ex               |97.4%     38| 100%     8|    -      0

Download coverage report

joshlarson
joshlarson requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reasonable way to add tests for this?

@firestack firestack force-pushed the kf/asn/fix-aws-location-search-text branch from 2226302 to 6fe8681 Compare August 1, 2024 14:52
@firestack
Copy link
Member Author

Is there a reasonable way to add tests for this?

how's this? 6fe8681 (#2702)

@firestack
Copy link
Member Author

oops, didn't mean to request both of you, but doesn't hurt I guess.

@firestack firestack enabled auto-merge (squash) August 1, 2024 14:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Coverage of commit 6fe8681

Summary coverage rate:
  lines......: 93.1% (3320 of 3566 lines)
  functions..: 72.6% (1357 of 1870 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/location_search/aws_location_request.ex               |97.4%     38| 100%     8|    -      0

Download coverage report

@joshlarson joshlarson disabled auto-merge August 1, 2024 17:14
joshlarson
joshlarson approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I disabled auto-merge because you had the deploy-to-dev-blue label on, and I didn't want to accidentally scoop you by merging while a dev-blue deploy was still pending.

Feel free to merge anyway if you already did the dev-blue testing you wanted to :)

@firestack firestack merged commit 98f8635 into main Aug 1, 2024
24 of 27 checks passed
@firestack firestack deleted the kf/asn/fix-aws-location-search-text branch August 1, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlarson joshlarson joshlarson approved these changes

@hannahpurcell hannahpurcell Awaiting requested review from hannahpurcell

Assignees

@joshlarson joshlarson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firestack @joshlarson @hannahpurcell