feat: Suppress "Add detour" dropdown on mobile #2716
Conversation
Coverage of commit
|
| @@ -213,6 +214,11 @@ const RouteLadder = ({ | |||
|
|
|||
| const displayCrowding = someVehicleHasCrowding(vehiclesAndGhosts, route.id) | |||
|
|
|||
| const screenSize = useScreenSize() | |||
There was a problem hiding this comment.
can we do this within CSS instead?
There was a problem hiding this comment.
We could - I think that would make it a bit more difficult to test, but perhaps that's okay?
There was a problem hiding this comment.
Yeah I'm not really sure we'd be able to test it until we have CSS in Jest tests, but that's fine with me. We could assert a certain class is on it, I think we just need to change it to d-none d-sm-block(replace block with whatever it's supposed to be), or something like that https://getbootstrap.com/docs/5.3/utilities/display/ (see the Hidden only on xs text)
There was a problem hiding this comment.
@firestack I updated to match ☝️, but I'm not sure that I love the lack of testability. I'll let it sit with me over the evening.
There was a problem hiding this comment.
@firestack I've let it sit with me, and while I don't love relying on snapshot tests, they will solve this issue.
Ready for re-review!
Coverage of commit
|
Asana Ticket: https://app.asana.com/0/1148853526253420/1207448960080664/f