Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MFA to logs #2726

Merged
merged 1 commit into from
Aug 5, 2024
Merged

feat: add MFA to logs #2726

merged 1 commit into from
Aug 5, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented Aug 2, 2024

Asana Ticket: https://app.asana.com/0/1205385723132845/1205805997139906/f

Example Searches:

Copy link

github-actions bot commented Aug 2, 2024

Coverage of commit 18b9d07

Summary coverage rate:
  lines......: 93.1% (3319 of 3566 lines)
  functions..: 72.6% (1357 of 1870 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack changed the title wip! add MFA to logs feat: add MFA to logs Aug 5, 2024
@firestack
Copy link
Member Author

note: I'd like to consider moving the [$level] to before the $metadata, since $level is more stable than $metadata, what do y'all think @mbta/skate-developers ?

I'd do this in another PR.

@firestack firestack marked this pull request as ready for review August 5, 2024 14:41
@firestack firestack requested a review from a team as a code owner August 5, 2024 14:41
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

@joshlarson
Copy link
Contributor

note: I'd like to consider moving the [$level] to before the $metadata, since $level is more stable than $metadata, what do y'all think @mbta/skate-developers ?

I'd do this in another PR.

I support this on all counts.

@firestack firestack merged commit 061791b into main Aug 5, 2024
57 checks passed
@firestack firestack deleted the kf/asn/mfa-logs branch August 5, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants