Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove configurable auth :provider in router, forcing keycloak #2728

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson added the do-not-merge Do not merge PR's with this label. label Aug 2, 2024
@joshlarson
Copy link
Contributor Author

Marked as do-not-merge because I want this to go to a deployed environment before merging.

Copy link

github-actions bot commented Aug 2, 2024

Coverage of commit 23bbebc

Summary coverage rate:
  lines......: 93.1% (3295 of 3541 lines)
  functions..: 72.5% (1357 of 1871 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate_web/router.ex                                         |88.9%     63|15.9%   138|    -      0

Download coverage report

@joshlarson joshlarson marked this pull request as ready for review August 2, 2024 18:29
@joshlarson joshlarson requested a review from a team as a code owner August 2, 2024 18:29
@joshlarson joshlarson removed the do-not-merge Do not merge PR's with this label. label Aug 7, 2024
@joshlarson
Copy link
Contributor Author

Confirmed in dev-blue that this does still work.

Base automatically changed from jdl/cleanup/remove-cognito to main August 7, 2024 18:32
@joshlarson joshlarson force-pushed the jdl/fix/make-auth-less-flexible branch from 23bbebc to 71666e9 Compare August 7, 2024 18:36
@joshlarson joshlarson enabled auto-merge (squash) August 7, 2024 18:36
@joshlarson joshlarson merged commit 8b2b317 into main Aug 7, 2024
9 checks passed
@joshlarson joshlarson deleted the jdl/fix/make-auth-less-flexible branch August 7, 2024 18:40
Copy link

github-actions bot commented Aug 7, 2024

Coverage of commit 71666e9

Summary coverage rate:
  lines......: 93.0% (3288 of 3534 lines)
  functions..: 72.5% (1357 of 1871 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate_web/router.ex                                         |88.9%     63|15.9%   138|    -      0

Download coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants