Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: move MBTA API config into runtime.exs #2759

Merged
merged 1 commit into from
Aug 28, 2024
Merged

cleanup: move MBTA API config into runtime.exs #2759

merged 1 commit into from
Aug 28, 2024

Conversation

firestack
Copy link
Member

Some small cleanup related to removing our Skate.Application.load_runtime_config/0 function

Related

@firestack firestack mentioned this pull request Aug 28, 2024
Merged
@github-actions GitHub Actions
Copy link

Coverage of commit c703fd2

Summary coverage rate:
  lines......: 93.0% (3299 of 3547 lines)
  functions..: 72.5% (1360 of 1876 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/application.ex                                        |94.1%     17|75.0%     4|    -      0

Download coverage report

@firestack firestack marked this pull request as ready for review August 28, 2024 13:14
@firestack firestack requested a review from a team as a code owner August 28, 2024 13:14
@firestack firestack force-pushed the kf/cleanup/mix-config/mbta-api branch from c703fd2 to 62dfabf Compare August 28, 2024 15:21
@firestack firestack enabled auto-merge (squash) August 28, 2024 15:21
@firestack firestack force-pushed the kf/cleanup/mix-config/mbta-api branch from 62dfabf to 74601f0 Compare August 28, 2024 15:24
@github-actions GitHub Actions
Copy link

Coverage of commit 74601f0

Summary coverage rate:
  lines......: 93.0% (3299 of 3547 lines)
  functions..: 72.5% (1360 of 1876 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/application.ex                                        |94.1%     17|75.0%     4|    -      0

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 74601f0

Summary coverage rate:
  lines......: 93.0% (3299 of 3547 lines)
  functions..: 72.5% (1360 of 1876 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/application.ex                                        |94.1%     17|75.0%     4|    -      0

Download coverage report

@firestack firestack merged commit d709d55 into main Aug 28, 2024
9 checks passed
@firestack firestack deleted the kf/cleanup/mix-config/mbta-api branch August 28, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlarson joshlarson joshlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firestack @joshlarson