feat: Space out components on detour list page #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
joshlarson
force-pushed
the
jdl/feat/space-out-detour-list-page
branch
from
0fb472a to
e26321e
Compare
firestack
reviewed
Sep 3, 2024
assets/css/_detour_list_page.scss
Outdated
Comment on lines
1
to
5
| .c-detour-list-page { | ||
| background-color: white; | ||
| } | ||
|
|
||
| .c-detour-list-page__button { | ||
| padding: 0.5rem 1rem 0.5rem 1rem; | ||
| margin: 24px 24px 36px 24px; | ||
| } |
There was a problem hiding this comment.
I love css, but is there a reason to do this and add to the bundle size vs using bootstrap utilities?
There was a problem hiding this comment.
Couple thoughts:
- I forgot to push a fix I had where I swapped all of these
px's forrem's, so this should actually bemargin-bottom: 2.25rem. - I can replace almost all of these with bootstrap utilities, except for
margin-bottom: 2.25rem. There's no bootstrap utility for2.25 * $spacer. - BUT... I think it still looks pretty good with
mb-4, which is1.5 * $spacer, so maybe we can ditch the CSS entirely for now.
There was a problem hiding this comment.
I changed my mind and added back in a teeny bit of CSS that enables the bigger margin. I replaced everything else with utilities though.
Coverage of commit
|
Coverage of commit
|
joshlarson
force-pushed
the
jdl/feat/space-out-detour-list-page
branch
from
d99b04e to
c60cf3a
Compare
Coverage of commit
|
Base automatically changed from
jdl/feat/update-borders-on-detour-list-table
to
main
September 4, 2024 17:58
joshlarson
force-pushed
the
jdl/feat/space-out-detour-list-page
branch
from
c60cf3a to
c2318e2
Compare
Coverage of commit
|
firestack
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Asana Ticket: https://app.asana.com/0/1205385723132845/1208155044119311/f
Depends on: