refactor: rename realtime.d.ts => realtime.ts
#2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/refactor/realtime
branch
from
f94c170 to
2687415
Compare
I'd like to add an `enum` to `realtime.d.ts` but turns out you can't really add and `enum` to a "definitions" file
firestack
force-pushed
the
kf/refactor/realtime
branch
from
2687415 to
e90f727
Compare
Coverage of commit
|
Coverage of commit
|
joshlarson
reviewed
Sep 3, 2024
| @@ -7,7 +7,7 @@ import { | |||
| TimepointId, | |||
| TripId, | |||
| ViaVariant, | |||
| } from "./schedule.d" | |||
| } from "./schedule" | |||
There was a problem hiding this comment.
Curiosity: Is there another schedule.d.ts ==> schedule.ts change associated with this, or can you import things from *.d.ts without the .d?
Looks like the build is passing, so it looks like this didn't break anything O_o
There was a problem hiding this comment.
AFAIK you can leave off all the extensions when importing, didn't notice this change though sorry!
I'd be open to reverting that if you feel strongly enough about it.
There was a problem hiding this comment.
No feelings whatsoever - I was just surprised that it worked.
joshlarson
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add an
enumtorealtime.d.tsbut turns out you can't really add andenumto a "definitions" file