Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Need to query the table in order of latest updates #2781

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: Need to query the table in order of latest updates #2781

merged 1 commit into from
Sep 10, 2024

Conversation

hannahpurcell
Copy link
Collaborator

Realized the db should be queried in order of most recently updated detours, for all cases.

@hannahpurcell hannahpurcell requested a review from a team as a code owner September 10, 2024 17:11
firestack
firestack approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Credo is gonna ask for a change but LGTM!

@github-actions GitHub Actions
Copy link

Coverage of commit d7850c9

Summary coverage rate:
  lines......: 93.0% (3317 of 3567 lines)
  functions..: 72.4% (1363 of 1882 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |87.5%     32|70.6%    17|    -      0

Download coverage report

@hannahpurcell hannahpurcell merged commit e51917e into main Sep 10, 2024
24 checks passed
@hannahpurcell hannahpurcell deleted the hp/fix-detour-sorting branch September 10, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahpurcell @firestack