-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Give the detours table timestamp columns different names depending on detour status #2787
Merged
firestack
merged 0 commits into
jdl/feat/empty-detour-table-icon
from
jdl/feat/different-timestamp-names-per-detour-table-type
Sep 19, 2024
Merged
feat: Give the detours table timestamp columns different names depending on detour status #2787
firestack
merged 0 commits into
jdl/feat/empty-detour-table-icon
from
jdl/feat/different-timestamp-names-per-detour-table-type
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
Coverage of commit
|
joshlarson
force-pushed
the
jdl/feat/icons-for-detour-table-headers
branch
from
September 11, 2024 17:53
b5f70cc
to
3bdd54b
Compare
joshlarson
force-pushed
the
jdl/feat/different-timestamp-names-per-detour-table-type
branch
3 times, most recently
from
September 11, 2024 18:23
a471330
to
ad59ade
Compare
joshlarson
changed the base branch from
jdl/feat/icons-for-detour-table-headers
to
jdl/feat/empty-detour-table-icon
September 11, 2024 18:24
joshlarson
force-pushed
the
jdl/feat/empty-detour-table-icon
branch
from
September 11, 2024 20:47
c0c3726
to
7e77b05
Compare
joshlarson
force-pushed
the
jdl/feat/different-timestamp-names-per-detour-table-type
branch
from
September 11, 2024 20:58
ad59ade
to
c283279
Compare
Coverage of commit
|
joshlarson
force-pushed
the
jdl/feat/different-timestamp-names-per-detour-table-type
branch
from
September 13, 2024 18:21
c283279
to
dec00ec
Compare
hannahpurcell
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great, thanks for throwing the invalid status
firestack
pushed a commit
that referenced
this pull request
Sep 19, 2024
changes: #2787 (and it's dependants)
firestack
pushed a commit
that referenced
this pull request
Sep 19, 2024
changes: #2787 (and it's dependants)
firestack
pushed a commit
that referenced
this pull request
Sep 19, 2024
changes: #2787 (and it's dependants) Update assets/src/components/detoursTable.tsx
firestack
added a commit
that referenced
this pull request
Sep 19, 2024
* feat: create detour status enum and "Timestamp Name" changes: #2787 (and it's dependants) --------- Co-authored-by: Josh Larson <jlarson@mbta.com>
firestack
force-pushed
the
jdl/feat/empty-detour-table-icon
branch
from
September 19, 2024 16:06
d7f3495
to
2e70104
Compare
firestack
deleted the
jdl/feat/different-timestamp-names-per-detour-table-type
branch
September 19, 2024 16:06
firestack
force-pushed
the
jdl/feat/different-timestamp-names-per-detour-table-type
branch
from
September 19, 2024 16:06
dec00ec
to
2e70104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Asana Ticket: https://app.asana.com/0/1205718271156548/1208214740600737/f
Depends on: