Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Give the detours table timestamp columns different names depending on detour status #2787

Conversation

joshlarson
Copy link
Contributor

Copy link

Coverage of commit a34ba24

Summary coverage rate:
  lines......: 93.0% (3318 of 3567 lines)
  functions..: 72.5% (1364 of 1882 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Copy link

Coverage of commit a34ba24

Summary coverage rate:
  lines......: 93.0% (3318 of 3567 lines)
  functions..: 72.5% (1364 of 1882 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@joshlarson joshlarson force-pushed the jdl/feat/icons-for-detour-table-headers branch from b5f70cc to 3bdd54b Compare September 11, 2024 17:53
@joshlarson joshlarson force-pushed the jdl/feat/different-timestamp-names-per-detour-table-type branch 3 times, most recently from a471330 to ad59ade Compare September 11, 2024 18:23
@joshlarson joshlarson changed the base branch from jdl/feat/icons-for-detour-table-headers to jdl/feat/empty-detour-table-icon September 11, 2024 18:24
@joshlarson joshlarson marked this pull request as ready for review September 11, 2024 18:25
@joshlarson joshlarson requested a review from a team as a code owner September 11, 2024 18:25
@joshlarson joshlarson force-pushed the jdl/feat/empty-detour-table-icon branch from c0c3726 to 7e77b05 Compare September 11, 2024 20:47
@joshlarson joshlarson force-pushed the jdl/feat/different-timestamp-names-per-detour-table-type branch from ad59ade to c283279 Compare September 11, 2024 20:58
Copy link

Coverage of commit c283279

Summary coverage rate:
  lines......: 93.0% (3318 of 3567 lines)
  functions..: 72.5% (1364 of 1882 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@joshlarson joshlarson force-pushed the jdl/feat/different-timestamp-names-per-detour-table-type branch from c283279 to dec00ec Compare September 13, 2024 18:21
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great, thanks for throwing the invalid status

firestack pushed a commit that referenced this pull request Sep 19, 2024
firestack pushed a commit that referenced this pull request Sep 19, 2024
firestack pushed a commit that referenced this pull request Sep 19, 2024
changes: #2787 (and it's dependants)

Update assets/src/components/detoursTable.tsx
firestack added a commit that referenced this pull request Sep 19, 2024
* feat: create detour status enum and "Timestamp Name"

changes: #2787 (and it's dependants)

---------

Co-authored-by: Josh Larson <jlarson@mbta.com>
@firestack firestack merged commit 2e70104 into jdl/feat/empty-detour-table-icon Sep 19, 2024
@firestack firestack force-pushed the jdl/feat/empty-detour-table-icon branch from d7f3495 to 2e70104 Compare September 19, 2024 16:06
@firestack firestack deleted the jdl/feat/different-timestamp-names-per-detour-table-type branch September 19, 2024 16:06
@firestack firestack force-pushed the jdl/feat/different-timestamp-names-per-detour-table-type branch from dec00ec to 2e70104 Compare September 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants