Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Activate detour flow #2793

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: Activate detour flow #2793

merged 1 commit into from
Sep 24, 2024

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented Sep 12, 2024

Screen.Recording.2024-09-12.at.6.59.18.PM.mov

Asana Ticket: https://app.asana.com/0/1205385723132845/1208153509160230/f

Base automatically changed from jdl/refactor/rename-activate-detour-test-file to main September 12, 2024 18:23
@joshlarson joshlarson force-pushed the jdl/feat/activate-detour-modal branch from d6788b0 to d66fad8 Compare September 12, 2024 20:56
@joshlarson joshlarson marked this pull request as ready for review September 12, 2024 22:54
@joshlarson joshlarson requested a review from a team as a code owner September 12, 2024 22:54
Copy link

Coverage of commit 2d2d8a3

Summary coverage rate:
  lines......: 93.0% (3318 of 3567 lines)
  functions..: 72.5% (1364 of 1882 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Copy link

Coverage of commit 2d2d8a3

Summary coverage rate:
  lines......: 93.0% (3318 of 3567 lines)
  functions..: 72.5% (1364 of 1882 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, why are the commits all the same message haha!

Looking so good! One issue, though: select a duration, click Cancel, then try to activate again. The modal still shows the selected duration, but also doesn't allow the user to proceed to "next". I believe a cancel should erase the selected duration.

Screenshot 2024-09-18 at 10 47 29 AM

@hannahpurcell
Copy link
Collaborator

Also, this is postponing hi-fi styling, right? Should I be leaving styling notes or save that for later?

Copy link

Coverage of commit 3decded

Summary coverage rate:
  lines......: 92.4% (3302 of 3572 lines)
  functions..: 71.5% (1365 of 1910 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@joshlarson
Copy link
Contributor Author

@hannahpurcell I think I've fixed the bug you found (well, I fixed the bug that I was smashing my head into earlier - who knew that guard clauses could be so wonderful ✨ - hopefully this is the same one)

Also, this is postponing hi-fi styling, right?

Yeah - hi-fi styling will come later, and TBH - it may come after we go live

@joshlarson joshlarson force-pushed the jdl/feat/activate-detour-modal branch from 013e2af to d061486 Compare September 23, 2024 20:17
@joshlarson joshlarson enabled auto-merge (squash) September 23, 2024 20:20
Copy link

Coverage of commit d061486

Summary coverage rate:
  lines......: 92.4% (3309 of 3580 lines)
  functions..: 71.4% (1365 of 1912 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@joshlarson joshlarson merged commit c3c4052 into main Sep 24, 2024
9 checks passed
@joshlarson joshlarson deleted the jdl/feat/activate-detour-modal branch September 24, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants