-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Activate detour flow #2793
Conversation
d6788b0
to
d66fad8
Compare
Coverage of commit
|
Coverage of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my, why are the commits all the same message haha!
Looking so good! One issue, though: select a duration, click Cancel, then try to activate again. The modal still shows the selected duration, but also doesn't allow the user to proceed to "next". I believe a cancel should erase the selected duration.
Also, this is postponing hi-fi styling, right? Should I be leaving styling notes or save that for later? |
assets/tests/components/detours/diversionPage.activate.test.tsx
Outdated
Show resolved
Hide resolved
2d2d8a3
to
3decded
Compare
Coverage of commit
|
@hannahpurcell I think I've fixed the bug you found (well, I fixed the bug that I was smashing my head into earlier - who knew that guard clauses could be so wonderful ✨ - hopefully this is the same one)
Yeah - hi-fi styling will come later, and TBH - it may come after we go live |
013e2af
to
d061486
Compare
Coverage of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Screen.Recording.2024-09-12.at.6.59.18.PM.mov
Asana Ticket: https://app.asana.com/0/1205385723132845/1208153509160230/f