Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Suppress "Return to regular route" button for non-dispatchers #2811

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat: Suppress "Return to regular route" button for non-dispatchers #2811

merged 1 commit into from
Sep 26, 2024

Conversation

joshlarson
Copy link
Contributor

No Asana Ticket, but I noticed this while playing around with detours, and didn't think it should be lumped in with #2805.

Depends on:

@joshlarson joshlarson requested a review from a team as a code owner September 24, 2024 19:46
@github-actions GitHub Actions
Copy link

Coverage of commit 370f350

Summary coverage rate:
  lines......: 92.5% (3310 of 3580 lines)
  functions..: 71.4% (1366 of 1912 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Base automatically changed from jdl/feat/deactivate-detour-modal to main September 25, 2024 19:39
@joshlarson joshlarson force-pushed the jdl/feat/suppress-regular-route-button-for-non-dispatchers branch from 370f350 to 58eb19e Compare September 25, 2024 20:25
@joshlarson joshlarson enabled auto-merge (squash) September 25, 2024 20:26
@github-actions GitHub Actions
Copy link

Coverage of commit 58eb19e

Summary coverage rate:
  lines......: 92.5% (3310 of 3580 lines)
  functions..: 71.4% (1366 of 1912 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

hannahpurcell
hannahpurcell approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like adding the identity check on the function for opening the deactivate modal 👍

@joshlarson joshlarson merged commit 8ed2dac into main Sep 26, 2024
9 checks passed
@joshlarson joshlarson deleted the jdl/feat/suppress-regular-route-button-for-non-dispatchers branch September 26, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlarson @hannahpurcell