Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added StepperBar to activate detour flow #2816

Merged
merged 4 commits into from
Sep 26, 2024
Merged

feat: Added StepperBar to activate detour flow #2816

merged 4 commits into from
Sep 26, 2024

Conversation

hannahpurcell
Copy link
Collaborator

@hannahpurcell hannahpurcell requested a review from a team as a code owner September 25, 2024 19:05
joshlarson
joshlarson approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

The build is being grumpy about a let statement, and I did make one cosmetic suggestion, but that's non-blocking.

@hannahpurcell @joshlarson
tweak: cosmetic suggestions from code review
640a8bb 
Co-authored-by: Josh Larson <jlarson@mbta.com>
@hannahpurcell hannahpurcell self-assigned this Sep 26, 2024
@github-actions GitHub Actions
Copy link

Coverage of commit ba1d138

Summary coverage rate:
  lines......: 92.5% (3310 of 3580 lines)
  functions..: 71.4% (1366 of 1912 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@hannahpurcell hannahpurcell merged commit f4d4bf7 into main Sep 26, 2024
9 checks passed
@hannahpurcell hannahpurcell deleted the hp/stepper-bar branch September 26, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlarson joshlarson joshlarson approved these changes

Assignees

@hannahpurcell hannahpurcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahpurcell @joshlarson