-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak: Move alert icon to route pill #2828
Conversation
Hmm, I don't agree with moving the alert icon into the route pill component, can you instead make the route pill component take either a I'm imagining something like this <RoutePill routeName={...} /> <RoutePill>
{hasAlert && (
<Tippy
content="Active detour"
trigger="click"
onShow={() => tagManagerEvent("alert_tooltip_clicked")}
>
<div className="c-route-ladder__alert-icon" aria-label="Route Alert">
<ExclamationTriangleFill />
</div>
</Tippy>
)}
<RoutePill.RouteName routeName={...} />
</RoutePill> OR name the component which takes the <RoutePill.Container>
{hasAlert && (
<Tippy
content="Active detour"
trigger="click"
onShow={() => tagManagerEvent("alert_tooltip_clicked")}
>
<div className="c-route-ladder__alert-icon" aria-label="Route Alert">
<ExclamationTriangleFill />
</div>
</Tippy>
)}
<RoutePill.RouteName routeName={...} />
</RoutePill> |
Ahhh totally. I did it simply, without using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question but otherwise lgtm
Asana ticket: https://app.asana.com/0/1205385723132845/1208333281632130
Talked with Kathleen async and decided a few things that are not captured in the handoff doc (given that the doc was medium-fi):