refactor:test(ex): use DataCase.setup_sandbox acording to phx.new template
#2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/update/phoenix/shared-db
branch
from
f3367b2 to
ec3ec18
Compare
firestack
force-pushed
the
kf/update/phoenix/shared-db
branch
3 times, most recently
from
974c885 to
96517f7
Compare
… template feat:test(ex/test): add database `setup_sandbox` function to `DataCase` This allows other test cases to configure the database via a shared function
firestack
force-pushed
the
kf/update/phoenix/shared-db
branch
from
96517f7 to
7a5a742
Compare
hannahpurcell
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows other test cases to configure the database via a shared function
https://github.com/phoenixframework/phoenix/blob/main/installer/lib/phx_new/generator.ex#L365-L366
https://github.com/phoenixframework/phoenix/blob/main/installer/templates/phx_ecto/data_case.ex#L39
https://github.com/phoenixframework/phoenix/blob/main/installer/templates/phx_single/test/test_helper.exs#L2
https://github.com/phoenixframework/phoenix/blob/8a0c5c7f0317f132c5f3757acdde58123051540f/installer/lib/phx_new/generator.ex#L363
https://github.com/phoenixframework/phoenix/blob/main/installer/templates/phx_test/support/conn_case.ex#L35