Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ex): configure check_origin for all transports on the SkateWeb.Endpoint #2895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

firestack
Copy link
Member

@firestack firestack commented Nov 4, 2024

This configuration has always confused me a little, mainly that we had to "implement" it ourselves.

So I tracked this down and confirmed that this can be configured via Application config

I do not know if this option was available at the time of #36 but now we can configure this via SkateWeb.Endpoint.

I loaded this up on dev-green and saw no changes or issues when loading the application.

This also seems to match other "modern" TID applications.


Depends on:

@firestack firestack marked this pull request as ready for review November 5, 2024 13:47
@firestack firestack requested a review from a team as a code owner November 5, 2024 13:47
Base automatically changed from kf/chore/plug-session-config to main November 14, 2024 13:49
@firestack firestack force-pushed the kf/chore/check-origin-config branch from eb3cbdf to 2c5634e Compare November 14, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant