Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dockerfile): update checksum for aws cert bundle #2901

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented Nov 20, 2024

The AWS RDS Cert bundle updated again and builds have been failing due to that.

Turns out, there is now a Dockerfile --checksum argument to the ADD command which both pulls something from the internet (like curl) but also can check the hash of the content at the same time.

This will also give us better logs when builds fail, and tell us what the new checksum is.
(Example log from when I initially added the ADD command, with a dummy checksum from the docs)

ERROR: failed to solve: digest mismatch sha256:390fdc813e2e58ec5a0def8ce6422b83d75032899167052ab981d8e1b3b14ff2: sha256:24454f830cdb571e2c4ad15481119c43b3cafd48dd869a9b2945d1036d1dc68d

Previously: #2746
Asana Ticket: https://app.asana.com/0/1148853526253420/1208798175282938/f

@firestack
Copy link
Member Author

firestack commented Nov 20, 2024

The part that was failing was the build part of the deploy, so even without the deploy succeeding (which I will keep trying) this is good to go @mbta/skate-developers

Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for my long delay, and thank you 🙏

@firestack firestack merged commit 70c3a07 into main Nov 25, 2024
27 of 28 checks passed
@firestack firestack deleted the kf/fix/aws-cert-bundle-checksum branch November 25, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants