feat: Detours channel #2908

hannahpurcell · 2024-12-11T00:21:24Z

Asana Ticket: https://app.asana.com/0/1205385723132845/1208600990461875

Depends on:

To try it out, I call

const skateDetours = useActiveDetoursByRoute(socket, selectedRouteIds)
console.log("skatedetours: ", skateDetours)

in routeLadders.tsx, and useActiveDetours(socket), usePastDetours(socket), and useDraftDetours(socket) in detourListPage.tsx.

Needs:

tests

lib/skate/detours/detours.ex

lib/skate_web/channels/detours_channel.ex

lib/skate/detours/detours.ex

Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>

assets/src/hooks/useDetours.ts

…tory

…etour)

…ving

test/skate_web/controllers/detours_controller_test.exs

test/skate_web/channels/detours_channel_test.exs

Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>

test/support/factories/detour_factory.ex

test/skate_web/channels/detours_channel_test.exs

assets/src/hooks/useDetours.ts

firestack

[Finished review]

test/skate_web/channels/detours_channel_test.exs

…r with author

test/support/factories/detour_factory.ex

firestack

One nit, but LGTM 👍🏻

Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>

feat: Set up detours channels

b55e03f

hannahpurcell requested a review from a team as a code owner December 11, 2024 00:21

firestack reviewed Dec 11, 2024

View reviewed changes

lib/skate/detours/detours.ex Outdated Show resolved Hide resolved

firestack reviewed Dec 11, 2024

View reviewed changes

lib/skate_web/channels/detours_channel.ex Outdated Show resolved Hide resolved

tweak: Mis-commit in detours.ex

59910e7

hannahpurcell commented Dec 11, 2024

View reviewed changes

lib/skate/detours/detours.ex Outdated Show resolved Hide resolved

hannahpurcell and others added 2 commits December 11, 2024 11:56

fix: channel name for active detours by route id

1df7bf2

Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>

tweak: make a function private

144976c

hannahpurcell changed the base branch from main to hp/move-user-filter-for-drafts December 11, 2024 19:35

hannahpurcell changed the base branch from hp/move-user-filter-for-drafts to main December 11, 2024 19:38

firestack reviewed Dec 12, 2024

View reviewed changes

assets/src/hooks/useDetours.ts Outdated Show resolved Hide resolved

hannahpurcell added 9 commits December 19, 2024 17:08

Merge branch 'main' into hp/skate-detours-channel

007ca7f

tweak: have a default list in grouped_detours

6d5b7b0

tweak: add value needed by db_detour_to_detour to detour_snapshot_fac…

c084049

…tory

tweak: delete unused line

64662b8

tweak: make author_id a FK to detours

e7ad20b

feat: Elixir tests for detoursChannel

0175b71

tweak: build user differently to avoid test failure (from broadcast_d…

b954e54

…etour)

fix: Big fixes to useActiveDetoursByRoute to help channel joins / lea…

090c05f

…ving

test: frontend tests for detour channels

014d5df

hannahpurcell force-pushed the hp/skate-detours-channel branch 2 times, most recently from a864baa to 5af2080 Compare December 19, 2024 22:34

tweak: formatting / credo

2c9023f

hannahpurcell force-pushed the hp/skate-detours-channel branch from 5af2080 to 2c9023f Compare December 19, 2024 22:39

firestack reviewed Dec 20, 2024

View reviewed changes

test/skate_web/controllers/detours_controller_test.exs Outdated Show resolved Hide resolved

firestack reviewed Dec 20, 2024

View reviewed changes

test/skate_web/channels/detours_channel_test.exs Outdated Show resolved Hide resolved

hannahpurcell and others added 3 commits December 20, 2024 16:30

tweak: test simplification

3456887

Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>

fix: spec typos fixed

9914136

fix: Channel name in broadcast for detours by route

8acf707

hannahpurcell mentioned this pull request Jan 3, 2025

tweak: Added hook for the recurrent pattern of loading one detour #2919

Merged

hannahpurcell force-pushed the hp/skate-detours-channel branch from deaf8ed to 3a909be Compare January 6, 2025 14:12

fix: don't mix-match route name and id!

18605d4

hannahpurcell force-pushed the hp/skate-detours-channel branch from 3a909be to 18605d4 Compare January 6, 2025 16:45

fix: Tests needed updated with detour parsing, but also caught a bug

071dcb2

hannahpurcell self-assigned this Jan 8, 2025

tweak: remove db population from set-up; put it in tests

ecd135c

Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>

hannahpurcell force-pushed the hp/skate-detours-channel branch from 8a8c7c2 to ecd135c Compare January 8, 2025 21:15

hannahpurcell requested a review from firestack January 8, 2025 21:26

hannahpurcell assigned firestack and unassigned hannahpurcell Jan 8, 2025

firestack reviewed Jan 9, 2025

View reviewed changes

test/support/factories/detour_factory.ex Outdated Show resolved Hide resolved

firestack reviewed Jan 9, 2025

View reviewed changes

test/skate_web/channels/detours_channel_test.exs Outdated Show resolved Hide resolved

firestack reviewed Jan 9, 2025

View reviewed changes

assets/src/hooks/useDetours.ts Show resolved Hide resolved

firestack reviewed Jan 9, 2025

View reviewed changes

assets/src/hooks/useDetours.ts Outdated Show resolved Hide resolved

firestack requested changes Jan 9, 2025

View reviewed changes

firestack assigned hannahpurcell and unassigned firestack Jan 9, 2025

hannahpurcell added 2 commits January 10, 2025 09:50

fix: use superstruct to validate data returned via channel

69b649c

fix: improve detour_factory to split name and id, then test SL

2fd43d5

hannahpurcell requested a review from firestack January 10, 2025 15:47

firestack reviewed Jan 10, 2025

View reviewed changes

test/skate_web/channels/detours_channel_test.exs Outdated Show resolved Hide resolved

fix: no need to use controller for that channel test! use build detou…

2d40aa8

…r with author

hannahpurcell requested a review from firestack January 10, 2025 17:39

hannahpurcell assigned firestack and unassigned hannahpurcell Jan 13, 2025

firestack reviewed Jan 14, 2025

View reviewed changes

test/support/factories/detour_factory.ex Outdated Show resolved Hide resolved

firestack approved these changes Jan 14, 2025

View reviewed changes

tweak: use available functions in detourfactory for simplicity

4d16bac

Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>

hannahpurcell merged commit d90c3f9 into main Jan 15, 2025
9 checks passed

hannahpurcell deleted the hp/skate-detours-channel branch January 15, 2025 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Detours channel #2908

feat: Detours channel #2908

hannahpurcell commented Dec 11, 2024 •

edited

Loading

firestack left a comment

firestack left a comment

feat: Detours channel #2908

feat: Detours channel #2908

Conversation

hannahpurcell commented Dec 11, 2024 • edited Loading

firestack left a comment

Choose a reason for hiding this comment

firestack left a comment

Choose a reason for hiding this comment

hannahpurcell commented Dec 11, 2024 •

edited

Loading