feat: delete draft detour UI #2909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
reviewed
Dec 19, 2024
Comment on lines
+389
to
+393
| routeName={routeName || "??"} | ||
| routeDescription={routeDescription || "??"} | ||
| routeOrigin={routeOrigin || "??"} | ||
| routeDirection={routeDirection || "??"} | ||
| /> |
There was a problem hiding this comment.
nit(non-blocking): what do you think of doing this via composistion instead of taking the various props?
affectedRoute={
<AffectedRoute
routeName={routeName ?? "??"}
routeDescription={routeDescription ?? "??"}
routeOrigin={routeOrigin ?? "??"}
routeDirection={routeDirection ?? "??"}
/>
}
| <BsIcons.Power /> | ||
| Start Detour | ||
| </Button> | ||
| {onDeleteDetour && ( |
There was a problem hiding this comment.
The onActivateDetour check has been lost, so users who do have "activation" permissions will lose access to the activation button if they don't have the "deletion" permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/1205385723132845/1208932353926619/f