-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite array's size in struct
, and argument of static_assert
and __builtin_frame_address
#293
Conversation
Failed on window because:
The corresponding function for window is
But this can't be used as test case, because different platform produce different dredd-mutated program. @afd Any suggestion to solve this? |
Please see It would be neat to have this tested with the Windows variant too, but it's not a priority so I wouldn't worry about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but there's one functional change I am slightly unsure about and would like to re-review.
A couple of language nits to be fixed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good! Various nits, and one slightly more substantial change please.
Enhances the support for rewriting the size expressions of
constant-sized arrays in
struct
fields. Additionally, rewrites thearguments' expressions of
static_assert()
and__builtin_frame_address()
, which need to be compile-time constants,while still allowing the constants that make up the expression— which
may also be referred to elsewhere— to be freely mutated.
Fixes #286 , Fixes #289 , Fixes #290