-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin incompatible with 10.0.0 SonarQube #753
Comments
Can confirm, The UI is making a request to Downgrading to the SonarQube 9.9.0 version working correctly |
FYI, I've also tested removing this plugin. It works without the community plugin. |
Sonarsource have updated the method names for checking feature status (https://github.com/SonarSource/sonarqube/blob/master/server/sonar-server-common/src/main/java/org/sonar/server/feature/SonarQubeFeature.java) so at the very least we'll need to alter our implementation of that class (https://github.com/mc1arke/sonarqube-community-branch-plugin/blob/master/src/main/java/com/github/mc1arke/sonarqube/plugin/server/CommunityBranchFeatureExtension.java), but also the Java Agent that redefines some of the bundled classes that implement those methods. I've not checked for other potential breaking changes in 10.0 yet |
Sonarqube 10 has removed legacy support for modules as well as removing deprecated properties historically used for specifying branch targets. Additionally, the interface for managing Sonarqube features has had a method renamed, which makes the new version of Sonarqube binary incompatible with the plugin. The references to Sonarqube's removed code have been removed from the plugin, and the implementations of the interface and Java agent that dynamically updates Sonarqube code that also implements the interface have been updated to use the new method name.
Sonarqube 10 has removed legacy support for modules as well as removing deprecated properties historically used for specifying branch targets. Additionally, the interface for managing Sonarqube features has had a method renamed, which makes the new version of Sonarqube binary incompatible with the plugin. The references to Sonarqube's removed code have been removed from the plugin, and the implementations of the interface and Java agent that dynamically updates Sonarqube code that also implements the interface have been updated to use the new method name.
Sonarqube 10 has removed legacy support for modules as well as removing deprecated properties historically used for specifying branch targets. Additionally, the interface for managing Sonarqube features has had a method renamed, which makes the new version of Sonarqube binary incompatible with the plugin. The references to Sonarqube's removed code have been removed from the plugin, and the implementations of the interface and Java agent that dynamically updates Sonarqube code that also implements the interface have been updated to use the new method name. As the Sonarqube server binaries are now compiled against Java 17, the build process has been bumped to JDK 17, but continues to produce Java 11 artefacts to allow scanner components to be compatible with the ongoing Java 11 support in the scanner.
Sonarqube 10 has removed legacy support for modules as well as removing deprecated properties historically used for specifying branch targets. Additionally, the interface for managing Sonarqube features has had a method renamed, which makes the new version of Sonarqube binary incompatible with the plugin. The references to Sonarqube's removed code have been removed from the plugin, and the implementations of the interface and Java agent that dynamically updates Sonarqube code that also implements the interface have been updated to use the new method name. As the Sonarqube server binaries are now compiled against Java 17, the build process has been bumped to JDK 17, but continues to produce Java 11 artefacts to allow scanner components to be compatible with the ongoing Java 11 support in the scanner.
Is there any plan to release a fix for this? |
Just pulled the |
same issue here. I've upgraded from 9.9 to 10.0.0 using the latest version of the plugin and got the loading screen too.. |
One way to bypass the loading screen is to set |
I am trying community branch plugin with 9.9 version & sonar is failing to load with error Current edition does not support branch feature |
+1 |
@washington-guedes where did you set that ? I guess here. |
sadly, that didn't work. |
How can i test this solution in my installation of sonarqube version 10? |
Same here. Using SonarQube v10. |
looks like 10.1 is out now. If someone tries it with 10.1 would be great to hear if this potential issue is still there. |
Anyone tried 10.1? Is the issue still there? |
10.1 isn't compatible with any version of this plugin, not even a pre-release version. I'll work out the required changes once I get time |
based on the branch: feature/sonarqube-10_0-support 1. upgrade sonarqubeVersion to '10.0.0.68432' 2. fixed dbClient.componentDao().insert(DbSession session, ComponentDto item, boolean isMainBranch) 3. fixed UT code
when the plugin is ready for 10.1 I figure it will work with 10.0 .... I'm on 9.9 right now so I figure I'll need to upgrade Version 9.9 (build 65466) to 10 ... which will probably need the plugin to do that ... and then to 10.1 ! :) thank you for doing this work @mc1arke |
I was able to build from https://github.com/bluebu/sonarqube-community-branch-plugin.git master branch: sonarqube@qat-sonarq-01: nothing to commit, working tree clean [+] Building 87.3s (12/12) FINISHED docker:default sonarqube@qat-sonarq-01:~/10.1.0-bluebu$ docker images -a |
How did you run the build? I tried to build the branch with my local jdk and gradle setup and also with Dockerfile which I found in the branch but build failed mostly with errors:
I would attach whole log but it is fairly lengthy. To reproduce just checkout |
Did you try running sonarqube with this plugin? I managed to build it too but when I run sonarqube with artifact from bluebu repo it failed to start. |
Sonarqube 10 has removed legacy support for modules as well as removing deprecated properties historically used for specifying branch targets. Additionally, the interface for managing Sonarqube features has had a method renamed, which makes the new version of Sonarqube binary incompatible with the plugin. The references to Sonarqube's removed code have been removed from the plugin, and the implementations of the interface and Java agent that dynamically updates Sonarqube code that also implements the interface have been updated to use the new method name. As the Sonarqube server binaries are now compiled against Java 17, the build process has been bumped to JDK 17, but continues to produce Java 11 artefacts to allow scanner components to be compatible with the ongoing Java 11 support in the scanner.
@xlatt download snapshot from the github actions. This link is for 10.1 |
Hi All, Any update on this issue, is SonarQube latest version is supporting community plugin? |
10.0 and 10.1 compatible versions have been published to Github and Dockerhub today |
@mc1arke Could you please share the links here for both. Is that Community Branch Plugin new version is released, that's what you are referring? |
The releases page of this repository lists all the releases, with the release notes stating compatibility against Sonarqube versions |
Describe the bug
Server bootstraps, but UI has an error that breaks any usage of the system.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
UI loads a list of projects.
Software Versions
The text was updated successfully, but these errors were encountered: