fix: omit https/2 pseudo headers #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
changed the title
mcansh
temporarily deployed
to
logan/omit-pseudo-headers - remix-fastify PR #422
Render
Destroyed
🦋 Changeset detectedLatest commit: 04cf410 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Logan McAnsh <logan@mcan.sh>
punkpeye
reviewed
Sep 14, 2024
| @@ -71,6 +71,7 @@ export function createRemixHeaders( | |||
| let headers = new Headers(); | |||
|
|
|||
| for (let [key, values] of Object.entries(requestHeaders)) { | |||
| if (key.startsWith(":")) continue; | |||
There was a problem hiding this comment.
I did need to add host from :authority though
|
I saw you closed this. Did you surface contrary to what I have? |
was a resolved upstream issue in Remix remix-run/remix#7867 - seems like thats more related to using |
|
thanks for letting me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #421