-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix asset serving when using a basename #442
Conversation
🦋 Changeset detectedLatest commit: 56604d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much!
hey @iamtomcat i still need to look at this locally, but if you rebase the changes from main, it should kick off a preview version of the package for you (and i, and any one else) to test out |
Cool will do in a bit here! |
commit: |
Signed-off-by: Logan McAnsh <logan@mcan.sh>
looks to be working great, thanks again (ex: https://github.com/mcansh/remix-fastify-442) (i really need to add some integration tests here 😅) |
No worries! The published package link was very useful btw. |
Hey when I use the basename in remix vite plugin and set base in vite locally assets are served at the same basename. But when using your plugin assets are still served at the root in production mode. So just made the change to respect the basename path.
If you want something that is more flexible let me know.