Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default from addr to 0.0.0.0:0 #48

Merged
merged 1 commit into from
May 3, 2023

Conversation

wayt
Copy link
Contributor

@wayt wayt commented May 2, 2023

Like #11

This sets the default from IP address to 0.0.0.0 which force the fallback on the underlying system to find the appropriate source IP depending on the destination (through routes).

We noticed that developers have no idea what value they should put here.

This doesn't remove the option of setting a custom value.

@wayt
Copy link
Contributor Author

wayt commented May 2, 2023

hey @mcasper 👋

First time contributing here, let me know if I missed something.

Happy to discuss this change.

@mcasper
Copy link
Owner

mcasper commented May 3, 2023

Looks good to me, thanks @wayt!

@mcasper mcasper merged commit f3f85e9 into mcasper:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants