Default system tags #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaeIsBad
reviewed
Aug 28, 2023
Comment on lines
+1133
to
+1142
| fn with_default_system_tags<T, F: FnOnce() -> T>(f: F) -> T { | ||
| std::env::set_var("DD_ENV", "production"); | ||
| std::env::set_var("DD_SERVICE", "service"); | ||
| std::env::set_var("DD_VERSION", "0.0.1"); | ||
| let t = f(); | ||
| std::env::remove_var("DD_ENV"); | ||
| std::env::remove_var("DD_SERVICE"); | ||
| std::env::remove_var("DD_VERSION"); | ||
| t | ||
| } |
There was a problem hiding this comment.
This causes flakiness. I've had test_new_default_tags randomly fail locally because of this.
There was a problem hiding this comment.
Can i propose to put in the readme something like a test section suggesting to test using the --test-threads 1?
mcasper
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mcasper,
I took inspiration, for this PR, to ruby dogstatsd library. The general idea of this PR is to automatically set the
env,serviceandversiontags in every metric we send. This could be accomplished settingDD_ENV,DD_SERVICEandDD_VERSIONenvironment variables.The code i refer to in the ruby dogstatsd library is this one
Please let me know if there's something else i can do and if you agree with this change.
Thank you in advance