Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

Broken integration with ktlint 0.32.0 #13

Closed
4brunu opened this issue Apr 23, 2019 · 10 comments
Closed

Broken integration with ktlint 0.32.0 #13

4brunu opened this issue Apr 23, 2019 · 10 comments

Comments

@4brunu
Copy link

4brunu commented Apr 23, 2019

Hey, today the ktlint version 0.32.0 was released and it broke this plugin.

Maybe because this version changed the package name.

Would you be ok with the idea of trying to merge this plugin in ktlint itself to prevent future issues in the future?

And in the meanwhile, could you try to fix this issue?
I will also take a look to see if I can fix it and submit a PR.
Thanks

@4brunu
Copy link
Author

4brunu commented Apr 26, 2019

@mcassiano this is resolved with the last merged PR, but I would like to know your thoughts on this:
Would you be ok with the idea of trying to merge this plugin in ktlint itself to prevent future issues in the future?

@mcassiano
Copy link
Owner

yeah, absolutely. i think making it part of ktlint could also help with versioning and maybe someone can contribute with a better looking design :)

@paristote
Copy link

Thanks for fixing the issue. Is it possible to release it please?

@jbaginski
Copy link

hey @mcassiano, would it be possible to do a release with this fix?

@mcassiano
Copy link
Owner

Hi all! Yes, I’ll publish this on JCenter this weekend (later today probably). Unfortunately this is a manual proccess since I don’t have the time to setup a CI build. Merging this reporter directly into ktlint might help in the future.

@mcassiano
Copy link
Owner

mcassiano commented May 3, 2019

Update: should be available through JitPack under 0.2.1. Uploading to JCenter now.
Update 2: should also be available through JCenter under 0.2.1.

@jbaginski
Copy link

thanks! 🚀

@shashachu
Copy link

@mcassiano looks like someone opened up a PR to bring your HTML reporter into the main ktlint project. (pinterest/ktlint#641) I am totally fine with this, but I'd feel better if it were you doing the PR. Would you be willing to open up a PR?

@mcassiano
Copy link
Owner

mcassiano commented Nov 12, 2019

Hey @shashachu. I instructed @arrmixer on how to open the PR. Feel free to continue the review or ping me if you’re still uncomfortable. I’ll subscribe to updates so I can make any changes if necessary :)

@shashachu
Copy link

@mcassiano sounds good. Can you just comment on the PR on ktlint to confirm that you're approving the change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants