Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Reporter #399

Closed
4brunu opened this issue Apr 23, 2019 · 16 comments
Closed

HTML Reporter #399

4brunu opened this issue Apr 23, 2019 · 16 comments

Comments

@4brunu
Copy link

4brunu commented Apr 23, 2019

Hey, it would be nice to have an HTML reporter.

Until now I've used https://github.com/mcassiano/ktlint-html-reporter, but with the new release 0.32.0 its broken, maybe because of the package rename.

It would be nice to integrate the HTML inside ktlint, to prevent future issues like this one.

@paristote
Copy link

I have the same issue, simply updating ktlint from v0.31 to v0.32 breaks the build, because the HTML reporter is not found. HTML reporter v0.1.2.

Error: reporter "html" wasn't found (available: checkstyle,json,plain).

@shashachu
Copy link
Contributor

I don't have a really strong opinion about whether we merge the HTML reporter into the main line. but you could also submit a pr on the HTML reporter project to update it for the new package namespaces.

@4brunu
Copy link
Author

4brunu commented May 2, 2019

I already did, and it was merged but the new version with the fix wasn't released yet.
mcassiano/ktlint-html-reporter#14
I would like to merge the plugin into the main repo to avoid future issues.

@4brunu
Copy link
Author

4brunu commented May 2, 2019

If you would be willing to accept PR with this, I could try to create one.

@shashachu
Copy link
Contributor

@4brunu would this be a new HTML reporter or actually copying https://github.com/mcassiano/ktlint-html-reporter/ into this codebase?

@4brunu
Copy link
Author

4brunu commented May 6, 2019

I was thinking in a copy of https://github.com/mcassiano/ktlint-html-reporter/

@JLLeitschuh
Copy link
Contributor

@4brunu
Copy link
Author

4brunu commented May 8, 2019

I'm not sure.

Not sure if it helps but the author of ktlint-html-reporter is ok with the idea of merging it in this project.
mcassiano/ktlint-html-reporter#13 (comment)

@mcassiano
Copy link

mcassiano commented Sep 13, 2019

Hi @shashachu! Are you still interested in moving with copying the reporter directly into ktlint's source? This could fix mcassiano/ktlint-html-reporter#19. I'm not actively using the reporter anymore but I can help with this "migration". I can make any changes to the licensing if needed.

@arrmixer
Copy link
Contributor

arrmixer commented Oct 6, 2019

Greetings! Just curious @shashachu @4brunu is the migration of @mcassiano’s library still a possibility?

Thank you

@4brunu
Copy link
Author

4brunu commented Oct 6, 2019

@arrmixer I think so.
I think the only problem was licensing.
If @mcassiano can change the licensing, I think it won't be difficult to make a PR and merge the html reporter here.
@mcassiano can you please change the license of your plugin?
Thanks

@Tapchicoma
Copy link
Collaborator

This could fix mcassiano/ktlint-html-reporter#19. I'm not actively using the reporter anymore but I can help with this "migration". I can make any changes to the licensing if needed.

As it was suggested in the issue, this reporter could be either used via local jar or added via build system (Gradle, Maven or any other). Ktlint had built-in dependency resolver, that is not supported anymore and has security issues. Updating it and maintaining it increases complexity of this project.

@Tapchicoma
Copy link
Collaborator

Html reporter PR was merged and should be available in the next release with other reporters.

@iamMehedi
Copy link

iamMehedi commented May 15, 2020

@Tapchicoma How to use that html reporter, tried --reporter=html,output=build/reports/ktlint.html but getting Error: reporter "html" wasn't found (available: checkstyle,json,plain)

@arrmixer
Copy link
Contributor

arrmixer commented May 16, 2020

@iamMehedi what version are you using. I think it was added in version 0.36.0.

@iamMehedi
Copy link

worked on 0.36.0, thanks @arrmixer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants