New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: implicit string concat makes the regex bad #444

Closed

edayot wants to merge 1 commit into mcbeet:main from edayot:beet_contrib_vanilla

Contributor

edayot commented Jul 24, 2024 •

edited

Loading

I had 50% failure on build, with a KeyError on the beet.contrig.vanilla plugin, this was due to the runtime order of the set :

{key, key.removesuffix(".*")}

Then I found this regex that used implicit string concatenation, I think I fixed it the right way.


          fix: implicit string concat makes the regex bad

df97178

edayot marked this pull request as ready for review

July 24, 2024 10:32

Member

vberlier commented Jul 24, 2024

Ah, you're right this is a typo, fixed it in v0.108.2.

vberlier closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet