Skip to content

Commit

Permalink
Removes without-hadoop dist and publishes dist tgz to the same locati…
Browse files Browse the repository at this point in the history
…on as the pom (apache#233)
  • Loading branch information
robert3005 authored Sep 22, 2017
1 parent 105e1b6 commit 2817552
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 195 deletions.
2 changes: 1 addition & 1 deletion dev/lint-java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)"

ERRORS=$($SCRIPT_DIR/../build/mvn -Pkubernetes -Pkinesis-asl -Pmesos -Pyarn -Phive -Phive-thriftserver checkstyle:check | grep ERROR)
ERRORS=$($SCRIPT_DIR/../build/mvn -Phadoop-cloud -Pkubernetes -Pkinesis-asl -Pmesos -Pyarn -Phive -Phive-thriftserver checkstyle:check | grep ERROR)

if test ! -z "$ERRORS"; then
echo -e "Checkstyle checks failed at following occurrences:\n$ERRORS"
Expand Down
2 changes: 1 addition & 1 deletion dev/make-distribution.sh
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ fi
echo "Spark version is $VERSION"
VERSION_SET=$("$MVN" versions:set -DnewVersion=$VERSION | tail -n 1)
if [ "$MAKE_TGZ" == "true" ]; then
echo "Making spark-dist-$VERSION-$NAME.tgz"
echo "Making spark-dist_2.11-$NAME-$VERSION.tgz"
else
echo "Making distribution for Spark $VERSION in '$DISTDIR'..."
fi
Expand Down
25 changes: 10 additions & 15 deletions dev/publish-local.sh
Original file line number Diff line number Diff line change
@@ -1,31 +1,26 @@
#!/usr/bin/env bash

set -euo pipefail
VERSION=$(git describe --tags)
HADOOP_VERSION=$(./build/mvn help:evaluate -Phadoop-palantir -Dexpression=hadoop.version 2>/dev/null\
| grep -v "INFO"\
| tail -n 1)

version=$(git describe --tags)

PALANTIR_FLAGS=(-Phadoop-cloud -Phadoop-palantir -Pkinesis-asl -Pkubernetes -Phive -Pyarn -Psparkr)

MVN_LOCAL="~/.m2/repository"

publish_artifacts() {
./build/mvn versions:set -DnewVersion=$VERSION
./build/mvn versions:set -DnewVersion=$version
./build/mvn -DskipTests "${PALANTIR_FLAGS[@]}" install clean
}

make_dist() {
dist_name="$1"
build_flags="$2"
shift 2
dist_version="${VERSION}-${dist_name}"
file_name="spark-dist-${dist_version}.tgz"
./dev/make-distribution.sh --name $dist_name --tgz "$@" $build_flags
mkdir -p $MVN_LOCAL/org/apache/spark/spark-dist/${dist_version} && \
cp $file_name $MVN_LOCAL/org/apache/spark/spark-dist/${dist_version}/
build_flags="$1"
shift 1
artifact_name="spark-dist_2.11-hadoop-palantir"
file_name="${artifact_name}-${version}.tgz"
./dev/make-distribution.sh --name "hadoop-palantir" --tgz "$@" $build_flags
mkdir -p $MVN_LOCAL/org/apache/spark/${artifact_name}/${version} && \
cp $file_name $MVN_LOCAL/org/apache/spark/${artifact_name}/${version}/
}

publish_artifacts
make_dist hadoop-$HADOOP_VERSION "${PALANTIR_FLAGS[*]}"
make_dist "${PALANTIR_FLAGS[*]}"
16 changes: 7 additions & 9 deletions dev/publish.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,13 @@ publish_artifacts() {
}

make_dist() {
dist_name="$1"
build_flags="$2"
shift 2
dist_version="${version}-${dist_name}"
file_name="spark-dist-${dist_version}.tgz"
./dev/make-distribution.sh --name $dist_name --tgz "$@" $build_flags
curl -u $BINTRAY_USERNAME:$BINTRAY_PASSWORD -T $file_name "https://api.bintray.com/content/palantir/releases/spark/${version}/org/apache/spark/spark-dist/${dist_version}/${file_name}"
build_flags="$1"
shift 1
artifact_name="spark-dist_2.11-hadoop-palantir"
file_name="${artifact_name}-${version}.tgz"
./dev/make-distribution.sh --name "hadoop-palantir" --tgz "$@" $build_flags
curl -u $BINTRAY_USERNAME:$BINTRAY_PASSWORD -T $file_name "https://api.bintray.com/content/palantir/releases/spark/${version}/org/apache/spark/${artifact_name}/${version}/${file_name}"
}

publish_artifacts
make_dist hadoop-2.8.0-palantir.8 "${PALANTIR_FLAGS[*]}" --clean
make_dist without-hadoop "-Phadoop-provided -Pkubernetes -Phive -Pyarn -Psparkr" --clean
make_dist "${PALANTIR_FLAGS[*]}" --clean
8 changes: 8 additions & 0 deletions dev/sparktestsupport/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,14 @@ def __hash__(self):
sbt_test_goals=["kubernetes/test"]
)

cloud = Module(
name="hadoop-cloud",
dependencies=[],
source_file_regexes=["hadoop-cloud/"],
build_profile_flags=["-Phadoop-cloud"],
sbt_test_goals=["hadoop-cloud/test"]
)

# The root module is a dummy module which is used to run all of the tests.
# No other modules should directly depend on this module.
root = Module(
Expand Down
168 changes: 0 additions & 168 deletions dists/without-hadoop/pom.xml

This file was deleted.

1 change: 0 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@
<module>external/kafka-0-10</module>
<module>external/kafka-0-10-assembly</module>
<module>external/kafka-0-10-sql</module>
<module>dists/without-hadoop</module>
<module>dists/hadoop-palantir</module>
</modules>

Expand Down

0 comments on commit 2817552

Please sign in to comment.