New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.cpp files have spurious #ifdef __cplusplus #127

Closed

terrillmoore opened this issue Feb 17, 2019 · 1 comment

Assignees

Labels

Member

terrillmoore commented Feb 17, 2019

The following files use #ifdef __cplusplus. This should be corrected, because .cpp files (unlike .h files) can not be anything else.

The C-isms should also be corrected.

Don't use #define in C++ files unless there's no alternative. #define can almost always be replaced by constexpr
Don't declare local functions extern "C" -- they can (and should) be C++, or even converted to private method functions.

My guess is that these are cut/paste errors after refactorings.

The text was updated successfully, but these errors were encountered:

terrillmoore added the enhancement label

terrillmoore self-assigned this

Member Author

terrillmoore commented Feb 17, 2019

I've corrected this. Will push a patches later today.

terrillmoore added a commit that referenced this issue


          Fix #127; make AnalogRead more debuggable chasing #125

381506b

terrillmoore closed this as completed in

e7b37e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment