Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt CatenaStm32L0Rtc::SleepForAlarm() for new STANDBY discipline #153

Closed
terrillmoore opened this issue Apr 15, 2019 · 1 comment
Closed

Adapt CatenaStm32L0Rtc::SleepForAlarm() for new STANDBY discipline #153

terrillmoore opened this issue Apr 15, 2019 · 1 comment
Assignees
@terrillmoore
Labels
enhancement

Comments

@terrillmoore
Copy link
Member

Although we won't use it, SleepForAlarm(SleepMode::Standby) should enter true STANDBY. We're changing the clients that used the older code.
@terrillmoore terrillmoore self-assigned this Apr 15, 2019
terrillmoore added a commit that referenced this issue Apr 15, 2019
@terrillmoore
Fix #153: call HAL_PWR_EnterTrueSTANDBYMode() for STANDBY
d9d4455
@terrillmoore terrillmoore mentioned this issue Apr 15, 2019
Closed
@terrillmoore
Copy link
Member Author

On reflection, this would be bad. SleepForAlarm(SleepMode::Standby) should always do a STOP, because people will expect it to return. If we need a true hibernate, we'll add StandbyForAlarm(), and mark it as __attribute__(noreturn).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore