New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LMIC_DEBUG_PRINTF is handy, but it needs to include a declaration #39

Closed

frankleonrose opened this issue Dec 7, 2017 · 1 comment

frankleonrose commented Dec 7, 2017

If you actually define -DLMIC_DEBUG_PRINTF MyLmicDebugPrintf you get warnings in compilation because it isn't declared in the LMiC modules.

I recommend adding a declaration immediately after #define

     #define LMIC_DEBUG_PRINTF(f, ...) LMIC_DEBUG_PRINTF_FN(f, ## __VA_ARGS__)
     extern void LMIC_DEBUG_PRINTF(const char *fmt, ...);

The text was updated successfully, but these errors were encountered:

frankleonrose mentioned this issue

Added declaration for LMIC_DEBUG_PRINTF_FN #41

Merged

Member

terrillmoore commented Dec 15, 2017

Fixed by 42dfb39

terrillmoore closed this as completed

terrillmoore added a commit that referenced this issue


          Update to V2.1.1 for fix for #39

0a9234e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment