Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NbTrans (LMIC.upRepeat) is not used to repeat unconfirmed messages #52

Closed
terrillmoore opened this issue Feb 7, 2018 · 1 comment
Closed

NbTrans (LMIC.upRepeat) is not used to repeat unconfirmed messages #52

terrillmoore opened this issue Feb 7, 2018 · 1 comment
Assignees
@terrillmoore
Labels
bug

Comments

@terrillmoore
Copy link
Member

The LoRaWAN 1.0.2 spec defines the NbTrans bits in LinkADRReq. The LMIC code correctly decodes the values in the MAC request, and copies NbTrans to LMIC.upRepeat; but after that, the values are not used.
@terrillmoore terrillmoore self-assigned this Feb 7, 2018
terrillmoore added a commit that referenced this issue Feb 12, 2018
@terrillmoore
Fix #52: Add LMIC.txRepeat and repeat uplink messages
ce6fd59
@terrillmoore
Copy link
Member Author

Fixed in #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore