Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certification now requires that we reject all attempts to change default channels #722

Closed
terrillmoore opened this issue Apr 29, 2021 · 0 comments
Assignees
Labels

Comments

@terrillmoore
Copy link
Member

terrillmoore commented Apr 29, 2021

The spec says this: LoRaWAN 1.0.3 section 5.6 (for NewChannelReq):

The acceptable range for ChIndex is N to 16.

In this case, N is our NUM_DEFAULT_CHANNELS. LMIC_setupChannel() is used for this, but it was less restrictive.

This is now tested in the EU Certification Test, section 5.2, and we fail because LMIC_setupChannel() is forgiving for changing the DRs of default channels.

Given our emphasis on compliance, rather than adding special code to handle MAC commands differently than the APIs, we'll simply tighten up the APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant