Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for TTGO-LoRa32-v2.1.6 #692

Merged
merged 5 commits into from
Oct 10, 2021
Merged

Support for TTGO-LoRa32-v2.1.6 #692

merged 5 commits into from
Oct 10, 2021

Conversation

ChrSchultz
Copy link

@ChrSchultz ChrSchultz commented Mar 21, 2021 •
edited
Loading

Added configuration for TTGO-LoRa32-v2.1.6;
works with latest arduino-esp32 package for Arduino. (esp32 Version >=1.0.5).
I've tested

Arduino settings: Tools->ESP32 Arduino->TTGO-LoRa32-v2.1.6.

@ChrSchultz
Copy link
Author

ChrSchultz commented Mar 21, 2021 •
edited
Loading

also tested with platformio. Its mandatory to run

pio platform update
to get latest framework for arduinoespressif32. (Version >=3.1.1);
or to set in platformio.ini platform = espressif32@3.1.1

@terrillmoore
Copy link
Member

@ChrSchultz thanks for your contribution.

Can you please figure out how to make the esp32 CI build? I don't use either esp32 or platformio, so I need help from contributors on this.

Thanks,
--Terry

@ChrSchultz
Copy link
Author

The ci test fails, due to FILEMIN Macro...
you can see if I simulate the test on my pc.
ci.log

terrillmoore
terrillmoore requested changes Jun 1, 2021
View reviewed changes
Copy link
Member

@terrillmoore terrillmoore left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please see the comments. Best regards, --Terry

src/hal/getpinmap_thisboard.cpp Outdated
Comment on lines 58 to 59
#elif defined(ARDUINO_MCCI_CATENA_4802)
return GetPinmap_Catena4802();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these deleted? Merge conflict?

src/hal/getpinmap_ttgo_lora32_v2.1.cpp
@@ -0,0 +1,67 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the changes I made for #736 -- it turns out that compilers don't actually do a great job of discarding vtables, so we need to condition this module compilation on defined(ARDUINO_TTGO_LoRa32_v21new).

src/hal/getpinmap_ttgo_lora32_v2.1.cpp
@@ -0,0 +1,67 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module should have a simple descriptive header to match the other files in this group.

terrillmoore added a commit that referenced this pull request Oct 10, 2021
@terrillmoore
Document change for #692
2268c5d
@terrillmoore terrillmoore merged commit a9652d4 into mcci-catena:master Oct 10, 2021
@terrillmoore
Copy link
Member

Thanks, merged with cosmetic changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrillmoore terrillmoore terrillmoore requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrSchultz @terrillmoore