add include for u1_t type #914
Conversation
|
@terrillmoore, what do you think about this pull request? |
|
I’m on deadline for a delivery for the day job. I’ll try to look at it tonight. Sorry for the delay.
Best regards,
…--Terry
From: Jacques Supcik ***@***.***>
Sent: Saturday, November 19, 2022 19:46
To: mcci-catena/arduino-lmic ***@***.***>
Cc: Terry Moore ***@***.***>; Mention ***@***.***>
Subject: Re: [mcci-catena/arduino-lmic] add include for u1_t type (PR #914)
@terrillmoore <https://github.com/terrillmoore> , what do you think about this pull request?
—
Reply to this email directly, view it on GitHub <#914 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AETP735Y6YXZTA2UZ5NMMQLWJFYF7ANCNFSM6AAAAAAR33X544> .
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AETP733VM2WLTNWTCPGHPWDWJFYF7A5CNFSM6AAAAAAR33X546WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSOXTS6O.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Thank you for the update. |
|
Looks good to me. Unfortunately, CI testing is broken, apparently due to a breaking change in arduino-cli. But I'll approve this, as it looks as if it's safe. |
|
Thank you. Do you want me to have a look at the CI testing issue within the Github action? |
|
If you have time, that would be great. The issue seems to be in the common script, where it calls arduino-cli -- for some reason, the platform isn't found. Obviously, something changed. Hopefully it's trivial. The script may be unpleasant to work on.... Otherwise, will plan to look at this after I make my release. |
|
I think I found the problem with the installation of the arduino-cli. See the pull request in the mcci-catena-ci project. |
|
Yep, I think you did too, thanks! Merged. I'll start a CI run now to confirm. |
If the
#include "hal/hal.h"comes before the#include "lmic.h", the compiler complains that theu1_tis not defined. This small change resolves this problem.