Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle zero-length downlink in Arduino_LoRaWAN::NetRxComplete #50

Closed
terrillmoore opened this issue Nov 11, 2018 · 1 comment
Closed

Handle zero-length downlink in Arduino_LoRaWAN::NetRxComplete #50

terrillmoore opened this issue Nov 11, 2018 · 1 comment
Labels
bug enhancement

Comments

@terrillmoore
Copy link
Member

When reviewing arduino-lmic docs, discovered that the proper form for checking for RX is:

if (LMIC.dataLen != 0 || LMIC.dataBeg != 0)

Right now we only have

if (LMIC.dataLen != 0)

which means that zero-length downlinks are not indicated to the client.
@terrillmoore
Copy link
Member Author

Labeled as a bug because I didn't intend to suppress zero-length downlinks.

terrillmoore added a commit that referenced this issue Nov 26, 2018
@terrillmoore
Merge pull request #61 from mcci-catena/issue50
19a0fbb 
Fix #50: handle zero-length payloads per spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore