Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return statement on Arduino_LoRaWAN::setFrequency #204

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

olicooper
Copy link
Contributor

Missing return statement on Arduino_LoRaWAN::setFrequency - causes compile errors. Could be related to an earlier issue I raised? #181

Missing return statement on Arduino_LoRaWAN::setFrequency - causes compile errors. Could be related to an earlier issue I raised? mcci-catena#181
@vkynchev
Copy link

I can confirm that adding return true; at the end of setFrequency method resolved the core panic on esp32...

@supcik
Copy link

supcik commented Nov 11, 2022

I also stumbled on this error

@klauweg
Copy link

klauweg commented Dec 11, 2022

Since i'm new to esp32/arduino/lorawan/c++ this cost me hours until i found this pull request :-).
Why can't it be merged with master soon?

@terrillmoore
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants