Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add /ws WebSockets endpoint #151

Closed
mccutchen opened this issue Nov 4, 2023 · 0 comments · Fixed by #155
Closed

feat: add /ws WebSockets endpoint #151

mccutchen opened this issue Nov 4, 2023 · 0 comments · Fixed by #155

Comments

@mccutchen
Copy link
Owner

mccutchen commented Nov 4, 2023

A /ws endpoint that provides a basic WebSockets-based echo server would be a useful addition, if it's not too difficult to implement without pulling in any external dependencies. MDN's guide to writing a WebSocket server might be a good starting point.

This would be very useful to help test HTTP proxies to ensure that they correctly support WebSockets, similar to the SSE endpoint proposed in #150.

We could potentially leverage something like https://github.com/crossbario/autobahn-testsuite to verify the basic functionality of the implementation, ideally wired up into our CI test suite.

mccutchen added a commit that referenced this issue Nov 25, 2023
Here we add a new `/websocket/echo` endpoint, which implements a basic
WebSocket echo service.

The endpoint is powered by our own basic, zero-dependency WebSocket
implementation, which passes _almost_ every test in the invaluable
[Autobahn Testsuite](https://github.com/crossbario/autobahn-testsuite)
"fuzzingclient" set of integration tests, which will be run
automatically as part of our continuous integration tests going forward.

Closes #151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant