Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests in parallel #82

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Run all tests in parallel #82

merged 2 commits into from
Jul 8, 2022

Conversation

mccutchen
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #82 (ef1e927) into main (0defb3c) will decrease coverage by 0.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   99.58%   99.06%   -0.53%     
==========================================
  Files           6        6              
  Lines         959      960       +1     
==========================================
- Hits          955      951       -4     
- Misses          2        6       +4     
- Partials        2        3       +1     
Impacted Files Coverage Δ
httpbin/handlers.go 99.13% <100.00%> (-0.87%) ⬇️

const maxDuration time.Duration = 1 * time.Second
const alphanumLetters = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
const (
maxBodySize int64 = 1024
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping this from 1024 * 1024 to 1024 accounts for almost all of the speedup by reducing the worse-case /drip test case run in < 1s instead of 10s.

@mccutchen mccutchen merged commit 86d5a04 into main Jul 8, 2022
@mccutchen mccutchen deleted the parallel-tests branch July 8, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants