Extract inline vars from the status handler #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is getting a bit into micro-optimization territory, but in the course of working on a bit of cleanup I realized there might be something to gain from making the
/status
endpoint a bit more efficient by initializing all the data it needs once instead of on every request.Results, from a set of highly unscientific vegeta benchmark runs on my laptop (3x per version):
before
after
That's a decent uptick in request rate and throughput and a decent drop in latency percentiles.