Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: stop being clever about when to rebuild #95

Merged
merged 1 commit into from
Nov 11, 2022
Merged

build: stop being clever about when to rebuild #95

merged 1 commit into from
Nov 11, 2022

Conversation

mccutchen
Copy link
Owner

Ran into an issue where the makefile did not think it needed to rebuild anything during a make watch session, which led to a decent amount of confusion. My make skills are not up to digging into how to handle this better and go build is fast enough, so let's just rebuild every time.

@codecov-commenter
Copy link

Codecov Report

Merging #95 (f1c7f15) into main (bd122ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files           6        6           
  Lines         900      900           
=======================================
  Hits          894      894           
+ Misses          4        3    -1     
- Partials        2        3    +1     
Impacted Files Coverage Δ
httpbin/helpers.go 97.40% <0.00%> (-1.25%) ⬇️
httpbin/httpbin.go 100.00% <0.00%> (ø)
httpbin/handlers.go 100.00% <0.00%> (+0.39%) ⬆️

@mccutchen mccutchen merged commit 579e061 into main Nov 11, 2022
@mccutchen mccutchen deleted the makefile branch November 11, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants